search

msysgit / git

msysGit-based Git for Windows 1.x is now superseded by Git for Windows 2.x
http://github.com/git-for-windows/git
Other
1.01k stars 316 forks source link

git-cheetah and GUI bugs when there's special characters #265

Closed fffonion closed 9 years ago

fffonion commented 10 years ago

These two bug reproduces when path contains a "・" (without quotes)

Normally git-cheetah would add three items(Git Init Here, Git Bash, Git GUI) to explorer right-click context menu when current is directory is not a git repository. But if path contains a "・", git-cheetah gives me 6 menu items as if this is a git repository.

And if I rename an existing git repository to some name containing "・", all features excepts git bash fails to launch.

I'm using version 1.9.4-preview20140929 on win8.1 x64, reproduce on win7 x64

dscho commented 10 years ago

I won't claim that I have time enough to even try to reproduce this issue, but I thought that I might want to mention that the chances of anybody stepping in to help will increase dramatically when it is made as easy as possible to reproduce the problem.

dscho commented 9 years ago

@fffonion do you have time to work on resolving this issue?

fffonion commented 9 years ago

@dscho I'm now in a travel. Will work on this as soon as I'm back :)

dscho commented 9 years ago

@fffonion okay. Please note that building Git Cheetah from source is now as easy as installing the Git for Windows SDK, then cloning https://github.com/msysgit/Git-Cheetah/ and running make in the checkout.

I would also like to ask you to open a Pull Request (even when you get stuck and the topic branch is not yet ready to merge) in the Git Cheetah project (because I am closing this ticket here: msysGit was retired in favor of the new Git for Windows 2.x).