search

mtarld / apip-ddd

An example of hexagonal API Platform 3 implementation
MIT License
321 stars 55 forks source link

Typo in shared services definition for kernel path #36

Closed Brewal closed 1 year ago

Brewal commented 1 year ago

https://github.com/mtarld/apip-ddd/blob/741d51ccd2a42fb044e9760b60948a206c069108/config/services/shared.php#L15

If I'm right, the Kernel path is src/Shared/Infrastructure/Symfony/Kernel.php.

I was a bit curious though... What I understood by debugging with the debug:container is that this typo has no effect on the services list in the container in the end since Symfony seems to override the definition for the kernel class anyway (with the "kernel" alias).

To me, it looks like this exclude (present in the default config of a strandard Symfony project) just improves performance a bit.

qualeo commented 1 year ago

I think https://github.com/mtarld/apip-ddd/blob/main/symfony.lock#L257 needs to be updated to reflect the new Kernel path.

mtarld commented 1 year ago

Nice catch! Thanks @Brewal and @qualeo :slightly_smiling_face: