mtgeekman / Home_Assistant_NeoSmartBlinds

Adds NeoSmart Blinds support to Home-Assistant.
46 stars 14 forks source link

Revert favourite 1 back to CMD_FAV #7

Closed clara-j closed 3 years ago

clara-j commented 3 years ago

In the case that there are controllers that don't support the i1/i2 commands and require gp for favourite 1, I have made it use that value for favourite 1.

From the tech support at neoblinds gp and i1 are equivalent. i2 will only be used for favourite 2.

Bacichetti commented 3 years ago

Hi, I work at Neo Smart Blinds.

I double-checked and gp and i1 are not universally equivalent. They are only equivalent for the users that have the motor supporting the second favourite position.

clara-j commented 3 years ago

Thank you for confirming. So this change should then resolve the issue since it will use gp for favourite 1 (50). This should work for all controllers, if I understand correctly. And then for favourite 2 (51) it will use i2 and will work for those controllers that support it.