search

mtr / angular-iscroll

AngularJS module that enables iScroll 5 functionality, wrapping it in an easy-to-use directive.
MIT License
74 stars 27 forks source link

asyncRefresh error on page change #29

Open riccardomarton opened 8 years ago

riccardomarton commented 8 years ago

Hi @mtr I'm using ngAnimate to mange page transitions and I set angular-iscroll to automatically refresh all istances every 500ms (refreshInterval: 500). Sometimes when i change page in my angular app, I get this error:

TypeError: Cannot read property 'length' of undefined
    at _indicatorsMap (iscroll.js:974)
    at Object.<anonymous> (iscroll.js:1007)
    at Object.IScroll._execEvent (iscroll.js:739)
    at Object.IScroll.refresh (iscroll.js:698)
    at _refreshAfterInitialRender (angular-iscroll.js:162)
    at angular.js:18132
    at completeOutstandingRequest (angular.js:5729)
    at angular.js:6006

I think it's because the module is trying to refresh a IScroll instance after the page is destroyed.

tomchiverton commented 8 years ago

Related to #13 ?

riccardomarton commented 8 years ago

Looks like it is! Sorry for the duplicate. I'll try to fix it when I have time

mtr commented 8 years ago

@riccardomarton and @tomchiverton: I am sorry, but I haven't been able to reproduce this nor the issue in #13. However, if any of you are able to both reproduce and fix the error situation, then I would be very happy if you would also submit a pull request for the solution.