search

mtth / avsc

Avro for JavaScript :zap:
MIT License
1.29k stars 148 forks source link

style: first start to move this package to TypeScript #479

Closed joscha closed 2 months ago

joscha commented 2 months ago

This adds typescript and transforms the smallest part (platform.js) to Typescript. It keeps everything else the same, including locations and ES level. This allows TS and JS to co-exist for the time being.

Screenshot 2024-09-25 at 8 43 35 PM

via https://github.com/mtth/avsc/issues/461#issuecomment-2370016950

relates to: https://github.com/mtth/avsc/issues/423, https://github.com/mtth/avsc/issues/128, https://github.com/mtth/avsc/issues/219

mtth commented 2 months ago

@joscha - I wish you gave me a heads up before putting effort in. After thinking about it, I think this migration is probably best done by me: to streamline maintenance, I would want to use the same TypeScript standard setup as my other projects.

joscha commented 2 months ago

@joscha - I wish you gave me a heads up before putting effort in. After thinking about it, I think this migration is probably best done by me: to streamline maintenance, I would want to use the same TypeScript standard setup as my other projects.

I did in

https://github.com/mtth/avsc/issues/461#issuecomment-2365245219

to which I got

https://github.com/mtth/avsc/issues/461#issuecomment-2370016950

and then

https://github.com/mtth/avsc/issues/461#issuecomment-2365245219

mtth commented 2 months ago

Yep, sorry - I didn't mean to imply that creating a PR would be a good next step here.

joscha commented 2 months ago

Yep, sorry - I didn't mean to imply that creating a PR would be a good next step here.

Well you know, open source would do that. I also think transforming it step by step with TS and JS side by side would make this much easier and allow other people to contribute.