search

muart-group / esphome

ESPHome fork for development of the mitsubishi_uart component. Check out the documentation for more info:
https://muart-group.github.io/
10 stars 1 forks source link

Add Filter Reset Button #39

Closed Sammy1Am closed 5 months ago

Sammy1Am commented 5 months ago

(Basically a duplicate of this PR from the old repo)

I successfully tested the Filter Reset button on my SVZ-KP30NA.

paravoid commented 5 months ago

AIUI, docs call this a "run status", while the code here calls it "run state". Either could work, but I think it'd be good for these to be aligned.

The docs call 0x04 "error state" rather than "error status", so they're not internally consistent either. (The code on the other hand calls this GetCommand::ERROR_INFO...)

Sammy1Am commented 5 months ago

Which docs?

These docs actually have "Get Run Status" but "Set Run State", so that should be made consistent. They use "Error State" as well.

I also noticed that "Run State" contains "Filter Status", and we also have "i-see Status"

I propose "State" for packet names, and "Status" for individual sensors/values (if for no other reason than that's requires the least change currently). Open to arguments for a different convention though.

Sammy1Am commented 5 months ago

Merged to make next PRs easier (avoid merge conflicts), but happy to continue discussion about State vs Status / Diagnostic for future PRs.

paravoid commented 5 months ago

Which docs?

These docs actually have "Get Run Status" but "Set Run State", so that should be made consistent. They use "Error State" as well.

Yep, these docs. You're right, they use both "run state" and "run status" interchangeably. I missed that!

I propose "State" for packet names, and "Status" for individual sensors/values (if for no other reason than that's requires the least change currently). Open to arguments for a different convention though.

That makes a lot of sense to me.