search

muckSponge / Optically-Realistic-Water

A Unity port of Martins Upitis' fantastic ocean water shader, which was originally coded in GLSL for Blender.
MIT License
173 stars 24 forks source link

Combine with Unity-gym #1

Open pengzhi1998 opened 2 years ago

pengzhi1998 commented 2 years ago

Thank you so much for this great implementation!

However, as I'm using it for our deep reinforcement learning training, I'm wondering whether this work could be combined with Gym? Because when I copy this project under the Gym-Unity project directory, the environment will not have a water effect anymore.

Thank you again and look forward to your reply!

muckSponge commented 2 years ago

Any object you want to be rendered with water needs to have the WaterUnder shader applied to it. This makes it a bit impractical to use and isn't something you'd want to use in production. It is more of a proof of concept to be improved upon with a more versatile implementation.

It also won't work in anything but the built in rendering pipeline (URP and HDRP are not compatible).

pengzhi1998 commented 2 years ago

I'm extremely sorry for the late reply. And thank you for your reply! But what do you mean URP and HDRP?

muckSponge commented 2 years ago

URP means Universal Rendering Pipeline and HDRP means High Definition Rendering Pipe. Sounds like you're not using those so you just need to use a material with the correct shader.

pengzhi1998 commented 2 years ago

Thank you! And actually, your implementation is VERY HELPFUL!!!