Clean up the code, add tests and CI

muellerberndt commented 5 years ago

Sabre was written as a proof-of-concept. Improve the code to fulfill professional standard, including:

Fix linter errors
Re-architect code if necessary (move stuff into libraries, etc.)
Add tests for all functionality (100% coverage if possible)
Set up integration tests with CircleCI
Set up automatic publishing of new releases to npm
Handle user errors and provide informative error messages
Document all available command line arguments in the README

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 3.5 ETH (566.78 USD @ $161.94/ETH) attached to it as part of the MythX fund.

If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
- Want to chip in? Add your own contribution here.
- Questions? Checkout Gitcoin Help or the Gitcoin Slack
- $56,795.84 more funded OSS Work available on the Gitcoin Issue Explorer

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Workers have applied to start work.

These users each claimed they can complete the work by 12 months from now. Please review their action plans below:

1) mul1sh has applied to start work _(Funders only: approve worker | reject worker)_.

Hi,

I believe I can get this done in 3 days or less. My plan of action is to start with fixing the lint errors, move the code into modules using lerna, then add mocha tests, setup Ci with circleCi and finally setup automatic pushing to npm for new releases from circleci

Learn more on the Gitcoin Issue Details page.

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work has been started.

These users each claimed they can complete the work by 11 months, 1 week from now. Please review their action plans below:

1) eswarasai has been approved to start work.

Will get the tests implemented and also proper documentation setup which provides an overview of usage of the library. I'll try to cleanup the code further while parallelly adding code coverage.

Learn more on the Gitcoin Issue Details page.

gitcoinbot commented 5 years ago

@eswarasai Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 5 years ago

@eswarasai Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 5 years ago

@eswarasai Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 5 years ago

@eswarasai Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 5 years ago

@eswarasai Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

muellerberndt commented 5 years ago

Hey @eswarasai, can you fix the currently open bugs as part of this bounty? That's #43, #45, #52, #53 and #54.

eswarasai commented 5 years ago

@b-mueller -- Sure. I'll take a quick look at all of them today and put in a fix for the rest except for resolving the imports which'll need some time on my end to figure out a solution. Thanks!

Skyge commented 5 years ago

@eswarasai I am not sure for the problem, but I have tested the #45

gitcoinbot commented 5 years ago

@eswarasai Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

@eswarasai due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

[x] reminder (3 days)
[x] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work for 3.5 ETH (556.13 USD @ $158.89/ETH) has been submitted by:

@eswarasai

@b-mueller please take a look at the submitted work:

PR by @eswarasai

Learn more on the Gitcoin Issue Details page
Want to chip in? Add your own contribution here.
Questions? Checkout Gitcoin Help or the Gitcoin Slack
$96,425.32 more funded OSS Work available on the Gitcoin Issue Explorer

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

The funding of 3.5 ETH (554.33 USD @ $158.38/ETH) attached to this issue has been approved & issued to @eswarasai.

Learn more on the Gitcoin Issue Details page
Questions? Checkout Gitcoin Help or the Gitcoin Slack
$95,765.65 more funded OSS Work available on the Gitcoin Issue Explorer

muellerberndt / sabre

Clean up the code, add tests and CI #39