Integrated Terminal setting fails

murchu27 commented 2 years ago

Issue Description

According to the official extension docs on launch.json options for debugging:

The "console" setting controls what console (terminal) window the target app is launched into.

One of the possible values for this setting is "integratedTerminal":

"integratedTerminal" : the target process will run inside VS Code's integrated terminal. Click the 'Terminal' tab in the tab group beneath the editor to interact with your application.

In the official extension, this option works fine. When debugging (i.e., pressing F5), VS Code launches an integrated terminal instance, and runs my program there, so that I can interact with it (e.g., with Console.ReadLine()).

However, when using this fork, no such terminal is launched, and I am unable to interact with any program that requires console input.

Steps to Reproduce

Install the VSIX of this extension from Open VSX, and install in VS Code.
Write a simple program that requires console input. I was following Microsoft's basic tutorial for this.
Create launch.json and tasks.json files (again, as per one of Microsoft's tutorials)
Debug the program by pressing F5

Expected Behavior

When the program builds, a new terminal instance should be opened (not just the build window), allowing me to interact with my console application.

This works fine using the official extension.

Actual Behavior

When the program builds, no new terminal instance is opened (besides the build window), and I can't interact with my console application.

NOTE: The screenshot shows that I have the official extension installed and disabled, alongside this fork. However, I also tried using this extension on a fresh install of VS Code without the official extension, and still encountered this issue. I have simply installed them side-by-side to show clearly that the error happens when I switch from the official extension to this one.

Logs

OmniSharp log

``` Starting OmniSharp server at 8/5/2022, 11:34:56 Target: /home/murchu27/repos/dotnet/HelloWorld OmniSharp server started. Path: /home/murchu27/.vscode/extensions/muhammad-sammy.csharp-1.24.4/.omnisharp/1.38.2/run PID: 32692 [info]: OmniSharp.Stdio.Host Starting OmniSharp on manjaro 0.0 (x64) [info]: OmniSharp.Services.DotNetCliService Checking the 'DOTNET_ROOT' environment variable to find a .NET SDK [info]: OmniSharp.Services.DotNetCliService Using the 'dotnet' on the PATH. [info]: OmniSharp.Services.DotNetCliService DotNetPath set to dotnet [info]: OmniSharp.MSBuild.Discovery.MSBuildLocator Located 1 MSBuild instance(s) 1: StandAlone 17.1.1 - "/home/murchu27/.vscode/extensions/muhammad-sammy.csharp-1.24.4/.omnisharp/1.38.2/omnisharp/.msbuild/Current/Bin" [info]: OmniSharp.MSBuild.Discovery.MSBuildLocator MSBUILD_EXE_PATH environment variable set to '/home/murchu27/.vscode/extensions/muhammad-sammy.csharp-1.24.4/.omnisharp/1.38.2/omnisharp/.msbuild/Current/Bin/MSBuild.exe' [info]: OmniSharp.MSBuild.Discovery.MSBuildLocator Registered MSBuild instance: StandAlone 17.1.1 - "/home/murchu27/.vscode/extensions/muhammad-sammy.csharp-1.24.4/.omnisharp/1.38.2/omnisharp/.msbuild/Current/Bin" CscToolExe = csc.exe MSBuildToolsPath = /home/murchu27/.vscode/extensions/muhammad-sammy.csharp-1.24.4/.omnisharp/1.38.2/omnisharp/.msbuild/Current/Bin CscToolPath = /home/murchu27/.vscode/extensions/muhammad-sammy.csharp-1.24.4/.omnisharp/1.38.2/omnisharp/.msbuild/Current/Bin/Roslyn BypassFrameworkInstallChecks = true MSBuildExtensionsPath = /home/murchu27/.vscode/extensions/muhammad-sammy.csharp-1.24.4/.omnisharp/1.38.2/omnisharp/.msbuild [info]: OmniSharp.WorkspaceInitializer Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.CSharpFormattingWorkspaceOptionsProvider, Order: 0 [info]: OmniSharp.Cake.CakeProjectSystem Detecting Cake files in '/home/murchu27/repos/dotnet/HelloWorld'. [info]: OmniSharp.Cake.CakeProjectSystem Did not find any Cake files [info]: OmniSharp.MSBuild.ProjectSystem No solution files found in '/home/murchu27/repos/dotnet/HelloWorld' [info]: OmniSharp.MSBuild.ProjectManager Queue project update for '/home/murchu27/repos/dotnet/HelloWorld/HelloWorld.csproj' [info]: OmniSharp.Script.ScriptProjectSystem Detecting CSX files in '/home/murchu27/repos/dotnet/HelloWorld'. [info]: OmniSharp.Script.ScriptProjectSystem Did not find any CSX files [info]: OmniSharp.WorkspaceInitializer Configuration finished. [info]: OmniSharp.Stdio.Host Omnisharp server running using Stdio at location '/home/murchu27/repos/dotnet/HelloWorld' on host 32604. [info]: OmniSharp.MSBuild.ProjectManager Loading project: /home/murchu27/repos/dotnet/HelloWorld/HelloWorld.csproj [info]: OmniSharp.MSBuild.ProjectManager Successfully loaded project file '/home/murchu27/repos/dotnet/HelloWorld/HelloWorld.csproj'. [info]: OmniSharp.MSBuild.ProjectManager Adding project '/home/murchu27/repos/dotnet/HelloWorld/HelloWorld.csproj' [info]: OmniSharp.MSBuild.ProjectManager Update project: HelloWorld Received response for /v2/getcodeactions but could not find request. ```

C# log

None

Environment information

⚠️⚠️ This report was from this extension which is a fork of the official extension

VSCode version: 1.67.0 C# Extension: 1.24.4

Mono Information

OmniSharp using built-in mono

Dotnet Information

.NET SDK (reflecting any global.json): Version: 6.0.102 Commit: 49861cb924 Runtime Environment: OS Name: manjaro OS Version: OS Platform: Linux RID: arch-x64 Base Path: /usr/share/dotnet/sdk/6.0.102/ Host (useful for support): Version: 6.0.2 Commit: 839cdfb0ec .NET SDKs installed: 6.0.102 [/usr/share/dotnet/sdk] .NET runtimes installed: Microsoft.NETCore.App 6.0.2 [/usr/share/dotnet/shared/Microsoft.NETCore.App] To install additional .NET runtimes or SDKs: https://aka.ms/dotnet-download

Visual Studio Code Extensions

|Extension|Author|Version| |---|---|---| |csharp|muhammad-sammy|1.24.4|;

ironsm4sh commented 2 years ago

This is an issue in netcoredbg (the debugger used in free-omnisharp-vscode). https://github.com/Samsung/netcoredbg/issues/80 The official extension works because it makes use of the non-free microsoft debugger.

mininmobile commented 2 years ago

it would be nice to have a warning when you try to do this

muhammadsammy / free-vscode-csharp