Janpot
commented
1 month ago I have tried to do the least amount of work possible. My thought is that we are likely to use more Netlify and Toolpad Studio in tandem as we move forward, so we likely want both to work. We also need to have a fallback for Toolpad as bundle size tracker feels like a critical tool, so if Toolpad Studio go away, we would need this, and last, I wasn't clear on how far we migrated the tool to Toolpad, I was wonder if we were missing anything.
So far, the only miss I see to fully migrate from this custom
to Toolpad Studio is search support, it's painful without it.
I'd imagine over time we steer away from Studio for this use case. I feel like the only reason it's implemented in Toolpad is to serve as dog-fooding. But the people maintaining it are not really the target audience. I'd rather imagine us to migrate the existing code to the X data grid instead to reduce code size and improve UX.
I'm not sure i understand the search support comment. Couldn't you filter the datagrid? The old netlify version doesn't have search support, right?
A quick fix for something that I noticed we regressed on from https://github.com/mui/material-ui/pull/44075.
The problems:
I have tried to do the least amount of work possible. My thought is that we are likely to use more Netlify and Toolpad Studio in tandem as we move forward, so we likely want both to work. We also need to have a fallback for Toolpad as bundle size tracker feels like a critical tool, so if Toolpad Studio go away, we would need this, and last, I wasn't clear on how far we migrated the tool to Toolpad, I was wonder if we were missing anything.
So far, the only miss I see to fully migrate from this custom to Toolpad Studio is search support, it's painful without it.
After: https://deploy-preview-212--mui-dashboard.netlify.app/size-comparison?circleCIBuildNumber=759483&baseRef=master&baseCommit=a25a365a4c66738f358ecd745bf3727c0ca9d5b6&prNumber=44075