Open helenginn opened 1 year ago
In Collection.h
we have a lot of size-based naming discrepancies, such as getCHDsVectorSize()
, countChdIds()
(there should only be one of these?).
getCountPids
which doesn't specify an object that I'm counting.
I'll start this issue as a comment thread to highlight instances where the naming practice isn't standardised for methods/functions which follow a similar theme. It doesn't really matter too much what the standard is, as long as the functions follow the same naming protocol.
Generally naming protocols should follow these rules:
ModelDataPair
(preferred) overMDP
, not to be interchanged with the "hidden" concept ofCollectionHasDataset
orCHD
.get
or never start withget
(as long as its consistent)set
Object
, we haveobjectSize()
ornumObjects()
orobjectCount()
and this format is used throughout all the mulch code.databaseObjectCount
, for example for getting the total number of collections.