muldjord / skyscraper

Powerful and versatile game scraper written in c++
GNU General Public License v3.0
487 stars 128 forks source link

Regeneration of gamelist for `pc/*.conf` files does not find cached entries when `pc/*.conf` filecontent is edited #333

Open Gemba opened 2 years ago

Gemba commented 2 years ago

Describe the bug Scraping info is dangling/orphaned in cache/db.xml when editing pc/*.conf files and updating from cache only (Skyscraper -p pc).

To Reproduce

  1. Create a *.conf file in platform pc/ for a well known PC game (i.e., one which has scraping info in the online databases)
  2. Scrape as usual from the different scraping sources with Skyscraper (with -s ...). gamelist gets created as expected with scraping data for that game
  3. Change the content of the *.conf file
  4. Run Skyscraper from cache to generate gamelist again (without -s)
  5. Identified: Information of the game relating to the created *.conf file does not show up in generated gamelist.xml
  6. Expected: gamelist.xml gets created with the game scraping info from cache.

Technical information

Additional context *.conf filecontent may be volatile until a proper config is found by the user and may be changed far more frequently than the *.conf filename itself. I assume the effect comes from the fact that the .conf extension is not listed in this codesegment: https://github.com/muldjord/skyscraper/blob/master/src/nametools.cpp#L494