search

muleyo / VideoAdBlockForTwitch

Blocks Ads on Twitch.tv.
GNU General Public License v3.0
1.62k stars 114 forks source link

Adblocker blocking entire stream in case of margin ads #82

Open garuna-m6 opened 1 year ago

garuna-m6 commented 1 year ago

Recently twitch started running non annoying ads in the margins of the stream, like

image

In such a case the extension tries to block the entire stream and points to no source, as the screenshot shows.

image

Is there a way where we can identify the ad type and block it in a better way. Seeing this issue for both chrome and firefox browser. Would love to help if guided a bit 🙏 .

TsukiZero commented 1 year ago

in addition, add an option to allow margin ads through, but not the full screen ads.

ghost commented 1 year ago

allow margin ads through

How about no?

TsukiZero commented 1 year ago

allow margin ads through

How about no?

how about you read for once?

in addition, add an option to allow margin ads through, but not the full screen ads.

Basically: OPTION to ALLOW Margin ads, as they DO NOT interfere the stream. Won't mean "Oh, Margin Ads by default will always be allowed to pass!" nor "Oh, Margin Ads will always be blocked", I mean giving the USER an OPTION, just like there's ALREADY an option in these extensions to allow or block ads without having to disable or uninstall the extension, or how you can flick the switch in an Userscript instead of having to delete the script.