search

mullvad / windows-service-rs

Windows services in Rust
Apache License 2.0
525 stars 85 forks source link

deps: update to windows-sys 0.52.0 #109

Closed poliorcetics closed 1 year ago

poliorcetics commented 1 year ago

windows-sys moved its MSRV to 1.56, which is less or equal to the one in this crate since the edition for windows-service is 2021, so no impact there.

Could we have a release after this is merged ? ~~I don't see any pub use of windows_sys:: stuff so a point release should be enough.~~ windows-sys is part of the public API so it would need a breaking release.

This change is Reviewable

faern commented 1 year ago

Thanks for the PR!

windows-sys is part of our public API. For example in a bunch of to_raw methods, such as ServiceAction::to_raw for example. This means we need to bump our version in a breaking way, not just a patch release. However, you should not bump the version in this PR. That's something we do when releasing as part of regular release work.

I don't know exactly what changed in the new version of the crate, but I guess it's nice we did not need any code changes to make it work :)

The CI fails, but I don't think it's because of these changes...

faern commented 1 year ago

Here is why the CI is failing: https://github.com/egor-tensin/setup-mingw/issues/15

faern commented 1 year ago

@poliorcetics We have now fixed the mingw issue. You can rebase this PR and push it to see if it works now.

poliorcetics commented 1 year ago

Thanks for the notif, rebased 👍

dlon commented 1 year ago

Thanks!