search

mullvad / windows-service-rs

Windows services in Rust
Apache License 2.0
525 stars 85 forks source link

Bump windows-sys version to 0.59 #133

Closed zaddach closed 1 month ago

zaddach commented 1 month ago

This updates the windows-sys version to 0.59.

This change is Reviewable

faern commented 1 month ago

This apparently bumps the MSRV. So you need to update the CI to run on 1.60.0 instead of 1.58.0. See the comment in build-and-test.yml

zaddach commented 1 month ago

I've updated the MSRV, and tested that both cargo test and cargo doc finish without errors.

faern commented 1 month ago

You need to update what Rust version the CI runs on. It still runs on 1.58. Please see https://github.com/mullvad/windows-service-rs/blob/main/.github/workflows/build-and-test.yml#L24-L28

Also don't forget my comment about the documentation links invalidly pointing to Security::SC_HANDLE

zaddach commented 1 month ago

Ahahah, I must still have been a bit tired in the morning. Forgot to actually add the files before committing. Here you go.