search

multiavatar / Multiavatar

Multicultural Avatar Generator in JavaScript
https://multiavatar.com
Other
1.78k stars 172 forks source link

Typescript support #9

Closed itpropro closed 3 years ago

itpropro commented 3 years ago

Hi, Any plans to provide types and to rewrite the library in typescript?

giekaton commented 3 years ago

Hi, no plans yet, but if this becomes a common request, then maybe I or someone else will do a rewrite in the future.

bengry commented 3 years ago

Added types via https://github.com/DefinitelyTyped/DefinitelyTyped/pull/56106. @giekaton If you prefer, I can close that PR and instead create one for this repo, so it wouldn't require users to install two packages (@multiavatar/multiavatar + @types/multiavatar__multiavatar (as a dev dependency)).

giekaton commented 3 years ago

Hi @bengry. Thank you for the contribution!

As I see, your code doesn't install any packages, which is good, as the philosophy of Multiavatar design is to keep everything as simple as possible and dependency-free.

Please create a PR for this repo. It would be great to have it very minimalistic. Don't close the one on DefinitelyTyped yet.