search

multiformats / go-multibase

Implementation of multibase parser in go
MIT License
33 stars 17 forks source link

Implement Identity encoding #10

Closed Kubuxu closed 7 years ago

Kubuxu commented 7 years ago

I have cleaned up: https://github.com/multiformats/go-multibase/pull/6 Bases off #9 @wigy-opensource-developer I hope you don't mind.

Resolves #6

wigy-opensource-developer commented 7 years ago

It is much simpler this way, indeed. I had a somewhat longer weekend, so I did not rebase #6... Please do not forget to do an official gx release that is integrated into ipfs/go-ipfs after reintegrating this.

whyrusleeping commented 7 years ago

Hrm... the point of multibase encoding is that things can be rendered and copy-pasted nicely. How does that end up looking with this?

(also, has @jbenet given input here? Please link me to it if so)

Kubuxu commented 7 years ago

Yes, but there are use cases where the multibase encoded hashes will for example, be sent over network. There is no reason to encode them into anything.

See https://github.com/multiformats/multibase/pull/19#discussion_r91863442 and https://github.com/multiformats/go-multibase/pull/6