munharsha / pe

0 stars 0 forks source link

Able to add a session before current date #10

Open munharsha opened 4 years ago

munharsha commented 4 years ago

I am able to add a session that is way before the current date. I agree that some classes might have already happen. But it does not make sense when i am allowed to key in a date like 1998 as that is way to early.

Screenshot 2020-11-13 at 12.58.26 PM.png

nus-pe-bot commented 4 years ago

Team's Response

This is a valid date in the correct format, which we are accepting. The validation for the date is for the validity as well as the formatting of the date.

at least state this in the UG. We have written this in the UG: The SESSION_DATE_TIME must be a valid date of the format dd-MM-yyyy HHmm.

Since the date you provided is a valid date and in the correct format, it should be accepted. Working as intended.

This scenario is very rare to occur in our normal usecase, so retagging as Low.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I agree that the format is correct. However, i believe the application should be also processing the date inputs even if the date is correct. It doesnt make sense to have a date of 1900 or 1800 when computers are not invented. Even though the scenario is rare this could happen if the user accidentally types in a date way to early. For example if he wants to type in year 2100 but keys in 1200 instead then it should give an error.


:question: Issue type

Team chose [type.FunctionalityBug] Originally [type.FeatureFlaw]

Reason for disagreement: [replace this with your explanation]


:question: Issue severity

Team chose [severity.Low] Originally [severity.High]

Reason for disagreement: [replace this with your explanation]