munharsha / pe

0 stars 0 forks source link

Wrong error message for delete student #9

Open munharsha opened 4 years ago

munharsha commented 4 years ago

When i typed a really an out of bounds number it shows the message that the index provided is invalid. However, when i put a negative value it shows a different message. I think they shluld both return the same message instead of saying invalid command format Screenshot 2020-11-13 at 12.55.01 PM.png

Screenshot 2020-11-13 at 12.54.26 PM.png

nus-pe-bot commented 4 years ago

Team's Response

This is inherited from AB3, no functionality changed. In case the tester is curious, this is because the - is taken as a token and it is not a numeric value, hence wrong format.

Additionally, it is clearly stated that the INDEX must be a positive integer in the error message, therefore the user has ample indication of what the correct usage should be. Changing to VeryLow due to the reasons stated.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]


:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]