search

munkhtegsh / f1-3-c2p1-colmar-academy

0 stars 0 forks source link

SUMMARY #6

Open rimmesbe opened 7 years ago

rimmesbe commented 7 years ago

Grade: Satisfactory

Summary: Good job on this final project, the site looks good on desktop and mobile. You used a lot of good techniques, glad to see you've learned a lot. Your image issues were coming from using the wrong image files. I would go through the issues I created and see if you can implement some fixes. I'd also suggest doing a little research on common css naming conventions and start implementing them. I like BEM, but there are many: http://getbem.com/introduction/

I'd put a little more time in to this project to make it look perfect. Usually the last 5% of a project is really where the best lessons are and the greatest challenges.

munkhtegsh commented 7 years ago

WoW! I'm so impressed by your comments, because I wasn't expected them to be so helpful. I tried to ask about the issues two other Codecademy mentors, but they could't find the problem about images. However, I didn't give up and left comments in my code and it helped. I'm really happy to meet you and thank you for telling me about http://getbem.com/. I will try to fix my issues soon and let you know. Have a great day!