muon-spectroscopy-computational-project / muon-galaxy

Data intensive science for everyone.
https://galaxyproject.org
Other
0 stars 0 forks source link

Add crystvis features #12 #25

Closed patrick-austin closed 1 year ago

patrick-austin commented 2 years ago

Closes #12 This adds support for relevant crystvis features through the Galaxy UI. image

Note that the export screenshot will only output a blank image. EDIT: Having looked into this some more, integrating with the existing Galaxy screenshot buttons would require a change to Crystvis, to allow us to provide generate a renderer with WebGLRenderer({preserveDrawingBuffer: true}). There may be some further tinkering required in Galaxy, but this would be the first step.

How to test the changes?

(Select all options that apply)

License

patrick-austin commented 1 year ago

Regarding the failing tests: after syncing with the latest upstream code, Mulled Unit Tests / Test (3.7), Test Galaxy packages / Test (3.7), and Test Galaxy packages / Test (3.10) are all failing upstream in the 22.05 release branch. The cause of Build docs / build (3.7) failure is documented in #27

github-actions[bot] commented 1 year ago

This PR was merged without a "kind/" label, please correct.