muonw / muonw-powertable

▦ PowerTable is a Svelte component that turns JSON data into an interactive HTML table. Inspired by DataTables. Powered by Svelte.
https://muonw.github.io/muonw-powertable/
Other
220 stars 13 forks source link

Options: Crud callbacks: deleteActionCallback, editSubmissionCallback #28

Closed mavcook closed 1 year ago

mavcook commented 1 year ago

Problem: Currently there is no way to update a remote database based on small edits in the PowerTable. This change adds two callbacks to allow use of PowerTable for CRUD apps.

Changes


Note: Apologies for any of my naivety here, and in any follow up discussion. This is my first time working on reactive front ends (and first time using javascript in a while; first time using typescript).

mavcook commented 1 year ago

Thanks for getting back so fast! Just wanted to check, are you ok with the callback names, or do you think they could be named better?

muonw-public commented 1 year ago

Thanks for getting back so fast! Just wanted to check, are you ok with the callback names, or do you think they could be named better?

I think the names deleteActionCallback and editSubmissionCallback properly represent what the functions do. But if you have come up with alternative names, please let me know.

mavcook commented 1 year ago

Those names work for me, just wanted to double check.