muratcorlu / ngx-script-loader

Angular 3rd party script loader
MIT License
33 stars 6 forks source link

Please update it to avoid warnings about peer dependencies #21

Closed sergeykosik closed 3 years ago

sergeykosik commented 4 years ago

Installing it with Angular 9.x gives me the following npm warnings:

npm WARN ngx-script-loader@1.3.0 requires a peer of @angular/common@>=6.0.0 <9.0.0 but none is installed. You must install peer dependencies yourself. npm WARN ngx-script-loader@1.3.0 requires a peer of @angular/core@>=6.0.0 <9.0.0 but none is installed. You must install peer dependencies yourself.

muratcorlu commented 4 years ago

I'll update dependencies with including Angular 9.

yuri-apanasik commented 4 years ago

better with Angular 10

bartholomej commented 3 years ago

Better with Angular 11 👍 Here: https://github.com/muratcorlu/ngx-script-loader/pull/31

muratcorlu commented 3 years ago

:tada: This issue has been resolved in version 2.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: