murgo / IrssiNotifier

notifies android phones from irc private messages
Apache License 2.0
171 stars 63 forks source link

Several improvements for the irssi script #86

Closed Juerd closed 12 years ago

Juerd commented 12 years ago

See commit messages for info.

murgo commented 12 years ago

Yeah, perl isn't really my forte, so thanks for these. :) The whole script is really half-assed and done with a "it-kinda-works-stop-messing-with-it" attitude (and it probably is REALLY evident from the script if you know perl). One thing about it, is the Open2-library common? As in, you'd expect it to be installed in basically any run-of-the-mill linux box with Irssi and wget and perl and all that?

One thing that I've been thinking about to implement is some kind of threading in the Irssi script, so the UI thread wouldn't freeze for the duration of the sending (which can take a while if the server is slowed down for some reason). I just couldn't have been bothered to study perl enough to learn to use threading (and possibly without having to use libraries that cannot be found pretty much everywhere). If you're fluent with perl and want to help, that's something that could be looked into. I've created an issue (27) for it before.

It's not really an important issue though, because usually you're not around Irssi anyway when you get notifications.

Anyway, thank you for the pull request!

Juerd commented 12 years ago

Lauri Härsilä skribis 2012-07-12 13:23 (-0700):

One thing about it, is the Open2-library common? As in, you'd expect it to be installed in basically any run-of-the-mill linux box with Irssi and wget and perl and all that?

Yes, it's part of the core distribution of Perl, which is in turn a dependency for Irssi itself.

I just couldn't have been bothered to study perl enough to learn to use threading

Perl is a great language, but don't use threading, especially not when writing Irssi scripts. Forking is fine, though.

Anyway, thank you for the pull request!

Expect more, when I have the time. I want to get rid of the wget call :)

Met vriendelijke groet, // Kind regards, // Korajn salutojn,

Juerd Waalboer juerd@tnx.nl TNX