musescore / MuseScore

MuseScore is an open source and free music notation software. For support, contribution, bug reports, visit MuseScore.org. Fork and make pull requests!
https://musescore.org
Other
12.13k stars 2.63k forks source link

[MU4 Issue] "Percussion" instrument has incorrect note assignments #10982

Closed dragonwithafez closed 2 years ago

dragonwithafez commented 2 years ago

Describe the bug The default drumset configuration for the Percussion instrument has some issues with the pitches being assigned to the wrong MIDI notes. For instance "Closed Hi-Hat" as defined in MU4 plays back as a completely different instrument. Viewing the drumset configuration reveals that Closed Hi-Hat is assigned to pitch number 27, whereas according to the General MIDI standard, it should be 42.

Instruments that I have found that have issues:

To Reproduce Steps to reproduce the behavior:

  1. Create a score using the Percussion instrument (found under Percussion - Unpitched)
  2. Add a Closed Hi-Hat or Ride Cymbal 1 pitch to the staff
  3. Note the incorrect playback

Expected behavior Instruments should sound according to how they are named

https://user-images.githubusercontent.com/57819859/160895543-8bfd9fe9-10da-4eb2-8faa-d650a6291942.mp4

Platform information OS: Windows 10 Version 2009, Arch.: x86_64, MuseScore version (64-bit): 4.0.0-2059952268, revision: github-musescore-musescore-abc123456

Additional context Does not occur in MU3 (at least not with the default sondfont, I haven't tried HQ in MU3). GM percussion map from https://musescore.org/sites/musescore.org/files/General%20MIDI%20Standard%20Percussion%20Set%20Key%20Map.pdf

GabeS573 commented 2 years ago

This does not occur in MuseScore 3 with HQ installed.

abariska commented 2 years ago

Looks like that. My bug is more general. There's not description needed, because our team already knows and fixes the issue. Currently, a huge spreadsheet with all mapping issues has been created and I only put them to one issue in GitGub. Sorry, I'm closing your ticket and Thanks for your attentiveness!