search

musescore / MuseScore

MuseScore is an open source and free music notation software. For support, contribution, bug reports, visit MuseScore.org. Fork and make pull requests!
https://musescore.org
Other
12.13k stars 2.63k forks source link

[MU4 Issue] Drumset Palette - Palette Order #11741

Closed lengthwave closed 2 years ago

lengthwave commented 2 years ago

Describe the bug Drumset palette order seems random instead of following order in instruments.xml

To Reproduce Steps to reproduce the behavior:

  1. Create score with any unpitched percussion instrument
  2. Enter note entry mode
  3. View Drumset Palette
  4. See error

Expected behavior Drumset Palette order should follow order as listed in instruments.xml

Screenshots

2022-05-25_11-34-51

Platform information OS: macOS 12.3, Arch.: x86_64, MuseScore version (64-bit): 4.0.0-2368923748, revision: github-musescore-musescore-8e6cd1f

abariska commented 2 years ago

@Tantacrul Really confusing thing. I'd put P2

HemantAntony commented 2 years ago

I can take a look. I hope this is as easy as it seems

Tantacrul commented 2 years ago

@boryskuzmenko - thanks. Done. @HemantAntony - yes please!

abariska commented 2 years ago

After discussion with @RomanPudashkin decided to close this issue as not actual. Better to leave the implementation as is (same as in MU3). Notes in drum palette use chromatic notes order and it makes sense. And linking to Instruments.xml is a bad idea due to this document has now fixed logic so can't be a reference for any instrument orders in the app