search

musescore / MuseScore

MuseScore is an open source and free music notation software. For support, contribution, bug reports, visit MuseScore.org. Fork and make pull requests!
https://musescore.org
Other
12.13k stars 2.63k forks source link

[MU4 Issue] Percussion beams on wrong side #12936

Closed rgreen5 closed 1 year ago

rgreen5 commented 2 years ago

Describe the bug Percussion staff stems and beams can be on the wrong side when entered from the on-screen Piano. I haven't tested a MIDI keyboard, but it is possible that the problem exists there as well.

To Reproduce

  1. Create a 5-line percussion staff score.
  2. In note-input mode, ensure voice 1 is selected and enter some eighth-note closed hihats (F#2) in measure 1 using the on-screen piano.
  3. Select voice 2 and enter some 1/4 note bass drum beats (C2) in the same measure using the on-screen piano.

RESULT: Voice 1 beams are on the wrong side of the notehead.

percussion_beams

Curiously, if you break all the beams using the "no beam" icon then UNDO, the beams appear on the correct side.

Expected behavior

Voice 1 Stems should point upwards in this case.

Platform information OS: Linux Mint 20.1, Arch.: x86_64, MuseScore version (64-bit): 4.0.0-2887048614, revision: github-musescore-musescore-61484bc

Tantacrul commented 1 year ago

@mike-spa / @asattely - can either of you fix this issue? Sounds quite bad.

MarcSabatella commented 1 year ago

FWIW, this may be more of a "note input" problem than an engraving problem (incorrect settings applied while entering notes). But see also https://github.com/musescore/MuseScore/issues/13783 for other symptoms that point to underlying issues with the note input process itself for drum notes when using MIDI / piano keyboard. The latter issue affects both MU3 and MU4. These issues may well be connected. In any event, the other issue is probably more of a limiter.

Tantacrul commented 1 year ago

Does the issue described here also affect MS3? If so, we could potentially move it to 4.x.

mike-spa commented 1 year ago

I think I actually have a fix, gonna make a PR soon

MarcSabatella commented 1 year ago

No, the beam direction issue does not occur in MU3. It's kind of moot because normally you get the wrong note entirely, so you basically can't use MIDI / piano input for drums in MU3. But interestingly, in those few cases where you do manage to get the right note, the beaming is actually correct in both versions. It's only the cases where you do get the right note that the beaming is wrong in MU4.

Tantacrul commented 1 year ago

I think I actually have a fix, gonna make a PR soon

Awesome.

Tantacrul commented 1 year ago

@rgreen5 / @MarcSabatella: will you check this when it's ready?

Currently testing a bunch of other PR's myself.

MarcSabatella commented 1 year ago

I tested, and it fixes both issues as advertised - nice job, @mike-spa!

Tantacrul commented 1 year ago

In that case @RomanPudashkin / @Eism - if you're happy, can we proceed to merge-ville?