musescore / MuseScore

MuseScore is an open source and free music notation software. For support, contribution, bug reports, visit MuseScore.org. Fork and make pull requests!
https://musescore.org
Other
12.38k stars 2.68k forks source link

Repeat shortcut doesn't work as expected in tablature #19589

Open rgreen5 opened 1 year ago

rgreen5 commented 1 year ago

Issue type

UI bug

Bug description

In a music staff, when in note input mode, the repeat shortcut (R) immediately repeats the last added chord. However, in tablature, the first repeat command advances the cursor but does not enter anything. You have to press repeat (R) again in order to enter the last chord: subsequently the repeat command acts as expected.

IMV, the repeat command should act the same way in tablature that it does in the music staff. That is, the first repeat command (R) should both advance the cursor and enter the last added chord.

Steps to reproduce

  1. Create a linked staff/tab score.
  2. In the music staff enter note input mode
  3. Press 5 (say) to enter a 5 fretmark on the 1st string.
  4. Press repeat
  5. Now repeat these actions in the tablature staff.

Actual result: In step 5, the first repeat command advances the cursor only. Expected result: In step 5, the first repeat command should advance the cursor and add the last chord.

MuseScore Version

MuseScore version (64-bit): 4.1.1-232071203, revision: github-musescore-musescore-e4d1ddf

Regression

No.

Operating system

OS: Linux Mint 20.1, Arch.: x86_64

MarcSabatella commented 1 year ago

A slight clarification: the note is being added, but since the cursor hasn't yet advanced, it's simply placed directly on top of the existing chord. You can see this by first selecting a new duration before pressing "R".

But yes, definitely pressing "R" should advance the cursor first, by the duration of the selected chord.

Can of worms to discuss elsewhere, but - do most guitarists actually like having the cursor not advance automatically for tablature? If that behavior were changed, then this issue would be moot.

rgreen5 commented 1 year ago

do most guitarists actually like having the cursor not advance automatically for tablature?

There's an obvious reason for having the cursor advance manually only, and that is to facilitate the entry of a chord; automatic advance would mean having to backspace each time to add the extra notes.

But in the case of the repeat shortcut the cursor should advance automatically from the get-go.

bkunda commented 10 months ago

It strikes me that the R key should just work the same for tab staves as it does for the standard stave (which it currently does, but only on the second press of the R key).