search

musescore / MuseScore

MuseScore is an open source and free music notation software. For support, contribution, bug reports, visit MuseScore.org. Fork and make pull requests!
https://musescore.org
Other
12.13k stars 2.63k forks source link

Accidentals probably should not be applied to non-pitched percussion #22713

Open zacjansheski opened 4 months ago

zacjansheski commented 4 months ago

Issue type

UX/Interaction bug (incorrect behaviour)

Bug description

It would be best to disable using accidentals on non-pitched percussion.

Steps to reproduce

  1. Open a score with Drum Kit
  2. In note input mode, use minus to engage the flat accidental
  3. Write a HiHat note, it is triple-flat (no change in playback)

Also you can select a note and then click the accidentals for some general midi fun.

Screenshots/Screen recordings

https://github.com/musescore/MuseScore/assets/69917893/abc59bd5-49a8-4530-9641-4d4b9b9dd7f4

MuseScore Version

OS: macOS 14.4, Arch.: x86_64, MuseScore Studio version (64-bit): 4.4.0-241280301, revision: github-musescore-musescore-63d04f9

Regression

No.

Operating system

Mac OS 14

Additional context

No response

TeeDeeY commented 4 months ago

When I imported some Apple Logic drum parts through MusicXML, there were some accidentals. Attached shows how notes connect to the GM midi standard. I hope MuseScore can expand (instead of limiting) to all of the GM parts, which includes accidentals. Musescore supports most of them.

IMG_7816

The source of the photo is https://support.apple.com/en-gu/guide/logicpro/lgsia2ae90f1/mac

zacjansheski commented 4 months ago

@TeeDeeY none of that should, in sheet music that humans read/play, be notated with accidentals. To support import, those midi pitches would need to be mapped on a percussion instrument and properly ID'd. (Most of them are mapped on the "Large Drum kit"). I think a GM kit that supports that specifically would be a feature request that should be logged separately.