search

mushorg / tanner

He who flays the hide
GNU General Public License v3.0
222 stars 104 forks source link

Fix #353 #357

Closed mzfr closed 4 years ago

mzfr commented 4 years ago

I have edited the delete_old_sessions function and now the connection between snare and tanner shouldn't break like that.

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 1169

Changes Missing Coverage Covered Lines Changed/Added Lines %
tanner/session_manager.py 0 1 0.0%
<!-- Total: 0 1 0.0% -->
Files with Coverage Reduction New Missed Lines %
tanner/session.py 4 72.88%
tanner/session_manager.py 6 71.05%
<!-- Total: 10 -->
Totals Coverage Status
Change from base Build 1152: -0.6%
Covered Lines: 1360
Relevant Lines: 1760
💛 - Coveralls
afeena commented 4 years ago

please read my comment https://github.com/mushorg/tanner/issues/353#issuecomment-591877587

afeena commented 4 years ago

I close this pull request because this break tanner functionality (removing function). If you want to continue working on this problem, please create the new one :)

mzfr commented 4 years ago

@afeena Since the solution is to rewrite the sessions reading from redis then I think it's better to leave this for GSoC process because one of the GSoC agendas is to shift from redis to something else.