mushorg / tanner

He who flays the hide
GNU General Public License v3.0
222 stars 104 forks source link

Fixed issue with installing dependencies #358

Closed puneet29 closed 4 years ago

puneet29 commented 4 years ago

The dependencies need to be installed in superuser mode else it results in errors.

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 1189


Totals Coverage Status
Change from base Build 1188: 0.0%
Covered Lines: 1403
Relevant Lines: 1838

💛 - Coveralls
mzfr commented 4 years ago

In my opinion, rather than changing the installation command to run with sudo we should add a command to build the virtual env and then run the installation command inside the venv without any sudo

Parth1811 commented 4 years ago

@puneet29 I have already added a PR with a better version of README in #355, please have a look I have added your suggestion as well. Also, I agree with @mzfr that there should be a virtual environment for TANNER, I would try to push a PR for that soon.

puneet29 commented 4 years ago

Yeah, I suggested for the virtual environment too @mzfr @Parth1811 Also, I will close this pr once yours is merged.

afeena commented 4 years ago

@puneet29 I've merged #355, please update your changes accordingly, thanks!

puneet29 commented 4 years ago

@afeena I've updated the pull request as requested.