Open sajadhsm opened 2 years ago
Your attentiveness is admirable!
Some of the content of this repository may seem less appropriate with Vue's update, and some of your suggestions are fine. My focus is not on Vue for the time being, if you can, PR welcome!
- In AppLink component, useAttrs and v-bind="attrs" can be removed because of Fallthrough Attributes
~I think it is not a good idea to do this. This will lose the type of the component props. If IDE or VLS can deduce the type of the component's root element, I think it makes sense to do so, and until then, I don't think it's good practice.~
I got it wrong :p
As I was reading through the source code, I've listed some minor issues which may improve the project:
mapValidationResponse
does not handle403
error<template #default>
for suspenseuseArticles
composable: 6.1. InfetchArticles
function, sincearticleType
can only have one value, it's better to useif-else
rather than onlyif
to skip other checks. 6.2getArticlesMeta
function is acting like a composable. So maybe it's better to rename it touseArticlesMeta
reactive()
. So it may be better to change current generic usage.AppLink
component,useAttrs
andv-bind="attrs"
can be removed because of Fallthrough AttributesI would like to help fix these issues if they are valid to you. :D