search

muun / falcon

Muun iOS wallet
https://muun.com
MIT License
196 stars 31 forks source link

Use github releases and publish .ipa file #9

Open emanuelb opened 3 years ago

emanuelb commented 3 years ago

Add .ipa file (ios app) to the releases as asset at github releases & add description of the release in: https://github.com/muun/falcon/releases

champo commented 3 years ago

Hi @emanuelb, what would you use an .ipa file for?

emanuelb commented 3 years ago

The primary objective for me is to test for reproducible-builds, see this comment for more details to understand why publishing the .ipa is needed: https://gitlab.com/walletscrutiny/walletScrutinyCom/-/issues/149#note_537109159

also I might look at the .ipa content as well and report related issues in it in this repo... so for me it's useful to testing (mostly security related), not usage as I don't have apple hardware (running macosx with Docker-OSX project)

emanuelb commented 3 years ago

also I use diffoscope tool to look at the diff between versions (not just to diff when reproducible-builds testing), in the past reported issues to diffoscope to support more files in apple apps that was uncovered due to diffing released files from different versions on github releases for some ios apps, publishing .ipa is useful for many reasons, the content in this comment & previous is the stuff that I do with .ipa files

champo commented 3 years ago

I see. We're a bit shorthanded on iOS right now so I don't think we'll be able to tackle this any time soon. We're due an overhual of our iOS build pipeline and will consider this request when we get there.