search

mvdevs / jk2mv

JK2MV - improved, modernized JK2 client and server
https://jk2mv.org
GNU General Public License v2.0
108 stars 33 forks source link

Fix pull/push effect on JKA models #148

Closed UncannyFish closed 2 years ago

UncannyFish commented 2 years ago

Quick video demonstration of that this pull request fix: (JK2 Kyle on the left, JKA Kyle on the right)

https://user-images.githubusercontent.com/64485842/177019032-4177a7ff-3d1a-4bc6-9896-61612a7d9d55.mp4

https://user-images.githubusercontent.com/64485842/177019034-4b2e41ed-5a9b-4131-be51-919d41fee3ac.mp4

I believe the issue was in OldToNewRemapTable. It was not remapping lhang_tag_bone to lhand. I also mapped ltail and rtail to lfemurYZ and rfemurYZ. I found custom JKA models using these bones for capes and skirts.

Daggolin commented 2 years ago

Haven't tested it myself, but the new code looks better than the old one. Does this also solve the issue with force grip being offset? Some users have recently mentioned such an issue with jka models, but I haven't looked into that, yet.

Are you sure it's a good idea to remove the "_off" stripping? I don't remember exactly what it was for, but I think it was a workaround for something the jka cgame module does and jk2 doesn't. This should get looked into and tested before merging this.

UncannyFish commented 2 years ago

I can't find find why _off stripping would be useful. I will look into it after some sleep. I haven't heard about grip, I will test it too.

UncannyFish commented 2 years ago

I tested force grip. Looks like it was fixed too with this new table. Previously it was offsetting like pull/push.

entdark commented 2 years ago

Could you show demonstration of the fix?

UncannyFish commented 2 years ago

Here is screenshots before fix. JK2 Kyle shot0002 JKA Kyle shot0003

After applying fix both Kyles look like on screenshot 1.