search

mvdevs / jk2mv

JK2MV - improved, modernized JK2 client and server
https://jk2mv.org
GNU General Public License v2.0
108 stars 33 forks source link

Fix cmake warning on Multithreaded params #158

Closed TriForceX closed 1 year ago

TriForceX commented 1 year ago

Set the params properly to prevent the next warnings when generating project files. CMake Warning (dev) at CMakeLists.txt:218 (set): implicitly converting 'TYPE' to 'STRING' type. CMake Warning (dev) at CMakeLists.txt:219 (set): implicitly converting 'TYPE' to 'STRING' type.

aufau commented 1 year ago

So what is this pr about?

TriForceX commented 1 year ago

So what is this pr about?

sorry i forgot to mention in the description, basically fix the warning when build project files due wrong params set

aufau commented 1 year ago

Will it work with older CMake versions? We have cmake_minimum_required(VERSION 3.1.0) currently and we don't want to bump it unless absolutely necessary.

TriForceX commented 1 year ago

yea it should be fine, ive noticed about this on my mod back in 2021 when cmake_minimum_required(VERSION 3.0) so i checked the documentation back then and updated, i never had any problems since then.

i just downloaded yesterday the jk2mv and mvsdk repos and noticed about this (using cmake 3.24.0) thats why i did the pr.