search

mvdschee / web-accessibility

A Visual Studio Extension for Web accessibility
https://marketplace.visualstudio.com/items?itemName=MaxvanderSchee.web-accessibility
MIT License
70 stars 12 forks source link

ARIA role rules applied too broadly #36

Closed Josh68 closed 4 years ago

Josh68 commented 4 years ago

https://github.com/mvdschee/web-accessibility/blob/9a5be3ed43291a9cc0a9d2af281fb76f1e3d5b58/server/src/accessibilityPatterns.ts#L68

Based on a discussion with an expert in web-a11y.slack.com, non-semantic elements like span and div are not required to have roles, and enforcing the application of a role on an element that doesn't need one may hurt accessibility.

The suggestion is to modify this rule / test so that it doesn't automatically flag any span or div without a role, at least when settings are at their default.

Thank you.

mellm0 commented 4 years ago

Yes, enjoy this extension but would like the ability to ignore this rule

mvdschee commented 4 years ago

He @mi3ll there is an option to disable this but with update 0.2.83 this will be the default :)