search

mvn23 / pyotgw

A library to interface with the OpenTherm Gateway through serial or network connection.
GNU General Public License v3.0
28 stars 16 forks source link

Add pre-commit and use serveral linters to ensure a consistent code style #12

Closed basnijholt closed 4 years ago

basnijholt commented 4 years ago

I've added pre-commit which runs a bunch of linters at each commit.

This ensures a consistent code-style throughout the project.

mvn23 commented 4 years ago

Thanks for the PR, I will have a look over the weekend.

basnijholt commented 4 years ago

Unfortunately, black is uncompromising and doesn't allow you to configure how it handles specific cases.

https://github.com/psf/black#the-uncompromising-code-formatter

So it's double quotes and limits the line length to 88.

mvn23 commented 4 years ago

So it's double quotes and limits the line length to 88.

So be it then :)

mvn23 commented 4 years ago

Awesome! Thanks again for the PR!