search

mvn23 / pyotgw

A library to interface with the OpenTherm Gateway through serial or network connection.
GNU General Public License v3.0
28 stars 16 forks source link

Make compatible with firmware 5.0 #27

Closed tjikkun closed 3 years ago

andriej commented 3 years ago

I thought it's a joke, but then I see new firmware.

tjikkun commented 3 years ago

Yes, not joking. New PS=1 output breaks stuff. THIS PR fixes that, but doesn't change anything else (I.e. it doesn't report or make use of the new stuff). Right now my HA install is broken without it :)

andriej commented 3 years ago

I'd have to learn how to update and know if there are any breaking changes :-)

tjikkun commented 3 years ago

On https://otgw.tclcode.com/changelog.html the incompatibility is mentioned:

Potential incompatibility: The PS=1 output has changed. If using this function, the program processing the information will have to be adapted accordingly.

Report additional values in a PS=1 report: 7 (Cooling control), 8 (Control setpoint 2), 19 (DHW flow rate), 23 (CH2 room setpoint), 31 (CH2 flow temperature), 33 (Boiler exhaust temperature), 70 (V/H master status), 71 (V/H control setpoint), 77 (Relative ventilation).

This PR should be backwards compatible with older firmware, while fixing compatibility with the newer one.

I don't know which firmware you are on, but updating should be very easy, if you use otmonitor

mvn23 commented 3 years ago

Thank you for the PR. I will be able to test this next week, so don't expect a merge before then. I would like to add the other new features as well before pushing an update to HA, so that may take a while longer.

tjikkun commented 3 years ago

Sure, no worries. I fixed it locally with pip install git+https://github.com/tjikkun/pyotgw.git@firmware_50 Works like a charm 👍🏻

mvn23 commented 3 years ago

Great, thanks! Where did you find the info on the DATA_VH parameters and message types?

tjikkun commented 3 years ago

I got it from https://www.opentherm.eu/wp-content/uploads/2016/06/OpenTherm-Function-Matrix-v1_0.xls

mvn23 commented 3 years ago

Thanks! Support for the newly added message types will be added in protocol.py as well, but with this PR get_status() is now fully updated.