mvysny / photocloud-frame-slideshow

Android Digital Photo Frame
https://www.android-photo-frame.eu
14 stars 1 forks source link

Make Google Photos Shared Album accessible with slideshow #130

Open andyfrei opened 4 years ago

andyfrei commented 4 years ago

Hey folks Is there any option we can make pictures from shared albums (not stored in the actual google account) accessible for photocloud slideshow?

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/91875066-make-google-photos-shared-album-accessible-with-slideshow?utm_campaign=plugin&utm_content=tracker%2F53303527&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F53303527&utm_medium=issues&utm_source=github).
mvysny commented 4 years ago

Sure thing! I haven't realized I need to call different API for shared albums :-D

In the File System Browser, I'm thinking of having two root folders, "Albums" and "Shared Albums"; entering "Albums" would show the list of your own albums as it is now, entering "Shared Albums" would show the list of all shared albums. Would that work for you?

Also, the Slideshow uses a bit different API to fetch photos from Google Photos. The "list all" API simply lists all of your photos; it's much quicker than getting the list of albums first, then crawling individual albums. However, it's not clear from the "list all" API documentation whether it returns only your media, or also media from shared albums. From your experience, does Slideshow shows only your media or also shared albums? If the Slideshow only shows your media, I will need to stop using the "list all" API, and resort to fetching the list of albums+shared albums+crawling. It's not a problem, but it's going to be a bit slower.

andyfrei commented 4 years ago

For now it shows only my media. As soon as I mark a shared album within Google photos to display alongside my own albums it shows up in slideshow including that media.So unsure if you should change the API, to be honest. If the other changes regarding filtering we were talking about also applies to content of shared albums regardless if shared album is "show in my albumlist" is ticked on or off I 2ould leave it as it is. If not I'd rather see them included in filters in the future...andyonthemove

-------- Ursprüngliche Nachricht --------Von: Martin Vysny notifications@github.com Datum: 08.05.20 22:11 (GMT+01:00) An: mvysny/photocloud-frame-slideshow photocloud-frame-slideshow@noreply.github.com Cc: Andy Frei andy.frei1981@gmail.com, Author author@noreply.github.com Betreff: Re: [mvysny/photocloud-frame-slideshow] Make Google Photos Shared Album accessible with slideshow (#130)

Sure thing! I haven't realized I need to call different API for shared albums. In the FileSystem browser, I'm thinking of having two root folders, "Albums" and "Shared Albums"; entering "Albums" would show the list of your own albums as it is now, entering "Shared Albums" would show the list of all shared albums. Would that work for you? Also, the Slideshow uses a bit different API to fetch photos. The API simply lists all of your photos; it's much quicker than getting the list of albums first, then crawling individual albums. However, it's not clear from the API documentation whether the API returns only your media, or also media from shared albums. From your experience, does Slideshow shows only your media or also shared albums? If the Slideshow only shows your media, I will need to stop using that API (and resort to fetching the list of albums+shared albums+crawling. It's not a problem, but it's going to be a bit slower).