mwalzer / psi-pi

Automatically exported from code.google.com/p/psi-pi
0 stars 0 forks source link

PeptideEvidenceList/@id needed? #58

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Do we need a PeptideEvidenceList element of type Identifiable (having attribute 
"id")? It is not referenced...

It seems, that <PeptideEvidenceList> is only necessary for grouping the 
<PeptideEvidence> elements together having the same <Enzyme_Ref> element(s)...

I have the feeling, that it will also not be references from outside the 
mzIdentML file.

Original issue reported on code.google.com by eisena...@googlemail.com on 3 Apr 2011 at 2:52

GoogleCodeExporter commented 9 years ago

Original comment by eisena...@googlemail.com on 3 Apr 2011 at 2:52

GoogleCodeExporter commented 9 years ago

Original comment by eisena...@googlemail.com on 3 Apr 2011 at 2:53

GoogleCodeExporter commented 9 years ago
While the id attribute doesn't really cause an overhead in itself and could be 
useful for future use cases. On the API level the ids are used to create lookup 
tables. Furthermore, there might be cases in the future where 
PeptideEvidenceLists are referenced from outside. In short, I can't really see 
the downside of having the id while it could be useful in the future.

Original comment by johannes...@gmail.com on 4 Apr 2011 at 2:32

GoogleCodeExporter commented 9 years ago

Original comment by eisena...@googlemail.com on 12 Apr 2011 at 9:35