Events not working with jupyterlab 1.0.0

mwcraig / ipyevents

A custom widget for returning mouse and keyboard events to Python. Documentation:

https://ipyevents.readthedocs.io/en/latest/index.html

BSD 3-Clause "New" or "Revised" License

112 stars 27 forks source link

Events not working with jupyterlab 1.0.0 #44

Closed prabhuramachandran closed 5 years ago

prabhuramachandran commented 5 years ago

Thanks for the really useful package and clean API. I just tried to run the example in doc/Widget DOM Events.ipynb and it works fine on a jupyter notebook but does not work with jupyterlab 1.0.0. No events are captured on jupyterlab. This is with ipyevents 0.5.0 from conda-forge and Python 3.7.3. Thanks.

jasongrout commented 5 years ago

To work in JupyterLab 1.0, this line: https://github.com/mwcraig/ipyevents/blob/ff15dd9992391a6d187aaf2582608ba29e312505/js/package.json#L41

needs to be updated to

 "@jupyter-widgets/base": "^1.0.4 || ^2",

prabhuramachandran commented 5 years ago

@jasongrout -- Thanks, I can confirm that this works!

prabhuramachandran commented 5 years ago

Sent PR for this in #45