search

mweststrate / relative-deps

Installs local dependencies for optimal developer experience
MIT License
428 stars 32 forks source link

fix: Fixed namespace packages + updated yarn.lock. #27

Closed michaeldowseza closed 4 years ago

michaeldowseza commented 4 years ago

Apologies but missed testing namespace packages in my original PR.

chrisheninger commented 4 years ago

Just came across this in my local development– 1.0.1 works but 1.0.2 does not work.

The error I'm getting is TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received undefined

I think that this PR would fix my issues– but for now I've rolled back and hard locked my dependency to 1.0.1.

mweststrate commented 4 years ago

Regenned the yarn file and merged. The proposed yarn file has a weird amazon proxy

mweststrate commented 4 years ago

Published as 1.0.3

browniefed commented 4 years ago

This PR broke all the things name space related.

michaeldowseza commented 4 years ago

Yup seems yarn and npm publish packages differently. Sigh. I wish there was a better way to test changes in this. My initial thought is to do the replacement of "@" based on if it's yarn or npm. Any thoughts or suggestions?

browniefed commented 4 years ago

I think that's the only option? I actually didn't realize this since I've used yarn for so long and thus my fix for 1.0.1 sufficed for me.

On Thu, Apr 30, 2020, 4:27 PM Michael notifications@github.com wrote:

Yup seems yarn and npm publish packages differently. Sigh. I wish there was a better way to test changes in this. My initial thought is to do the replacement of "@" based on if it's yarn or npm. Any thoughts or suggestions?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/mweststrate/relative-deps/pull/27#issuecomment-622172552, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANCT4M5TZPQ73JLGO56NMLRPICOPANCNFSM4MHSRFYA .

michaeldowseza commented 4 years ago

And my experience is all in npm 😅 I'll see if I can submit a new PR tomorrow. I'm still wondering how I can properly test it all though. The last PR I basically had my project branch + 2 smaller projects where I tried to cover the basic yarn/npm cases in ubuntu and Windows but it still seemed easy to miss a very basic use case :/

zhangwilling commented 4 years ago

the problem is can't find .tar.

Use ["pack", "--filename", tmpName] to fix it . And this way is former handler.