Attempt to provide partial fix for Issue #64.

mwild1 / luadbi

Multi-backend SQL database library for Lua

MIT License

38 stars 14 forks source link

Attempt to provide partial fix for Issue #64. #75

Closed sparked435 closed 4 months ago

sparked435 commented 4 months ago

I'm not willing to commit this right away, because for $REASONS, I am unable to get access to a workable MySQL 8 instance at this time.

However this commit appears to properly send integers and not floating point numerics to MySQL if the actual Lua type is integer. printf() debugging shows both branches are exercised by the test suite.

sparked435 commented 4 months ago

There's been a lot of minor bugfixes over the past couple of years since 0.7.2. If this resolves issue #64 I recommend we release version 0.8.

sparked435 commented 4 months ago

This works against MySQL 8.0.36. Removing the code within the ifdef at line #236 of dbd/mysql/statement.c breaks the test_select_limit test case.