search

mxgross / EasyBackupBundle

Kimai 2 Plugin for easier backups
MIT License
24 stars 6 forks source link

Files and paths to backup settings: only last path taken into account #33

Closed biologghe closed 3 years ago

biologghe commented 3 years ago

In my hands (Firefox Browser on Windows 10 Enterprise and Kimai 1.12 stable running on Pi) the paths entered in the settings 'Files and paths to backup) are not all taken into account. Only when content of the form field is deleted and saved (= defaults are taken) all files and folders are taken into account. As the default values are filled in automatically, you need to remember to delete the content every time you make changes to other settings. Looks like a PHP_EOL issue (https://eidson.info/post/php_eol_is_broken)

biologghe commented 3 years ago

Should have checked dev branch. Fixed already ...

mxgross commented 3 years ago

Hi, thanks for looking at the dev branch. I would really appreciate if you would like to test the new restore functionality. I did not merge it to the master yet because I only tested it in my environments.

Best regards, Max

biologghe commented 3 years ago

Hi Max, What is the best/easiest channel to communicate with? (this is reply to email notification).

FYI I did a restore attempt but bumped into this error: [2020-12-27 15:48:00] request.CRITICAL: Uncaught PHP Exception Symfony\Component\Filesystem\Exception\IOException: "Cannot rename "/home/pi/kimai2/var/easy_backup/2020-12-27_151908/.env" to "/home/pi/kimai2/.env"." at /home/pi/kimai2/vendor/symfony/filesystem/Filesystem.php line 290 {"exception":"[object] (Symfony\Component\Filesystem\Exception\IOException(code: 0): Cannot rename \"/home/pi/kimai2/var/easy_backup/2020-12-27_151908/.env\" to \"/home/pi/kimai2/.env\". at /home/pi/kimai2/vendor/symfony/filesystem/Filesystem.php:290)"} []

I had changed the permissions of .env to g+rw

HTH, Marc

On Sat, Dec 26, 2020 at 9:51 PM mgross notifications@github.com wrote:

Hi, thanks for looking at the dev branch. I would really appreciate if you would like to test the new restore functionality. I did not merge it to the master yet because I only tested it in my environments.

Best regards, Max

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/mxgross/EasyBackupBundle/issues/33#issuecomment-751394859, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANHV7EAVC46HELP2U7HZH3SWZEDXANCNFSM4VKGBVEQ .