search

mxgross / EasyBackupBundle

Kimai 2 Plugin for easier backups
MIT License
24 stars 6 forks source link

Backup command #51

Closed mxgross closed 1 year ago

mxgross commented 1 year ago

I uploaded a new version, but I need to test it on a fresh installation again tomorrow. Command::SUCCESS does somehow not work, maybe my dev installation is messed up. Undefined constant Symfony\Component\Console\Command\Command::SUCCESS

I moved code in service class but did not yet cleanup my controller completely.

kevinpapst commented 1 year ago

Hm, maybe these Command:: constants are not available in Symfony 4.x. Sorry, due to the work with the next major version of Kimai and Symfony 6 I get mixed up...

mxgross commented 1 year ago

Hi @kevinpapst I implemented your suggestion and just tested the command and the manual backup triggering (via button) in a fresh Kimai2 1.30.3 installation.

Please let me know if you have any other improvements or if we should merge it. Thanks a lot.

kevinpapst commented 1 year ago

I haven't tested it, it was just some feedback while reading through the code.

But if it works for you then GO 🚀

😄