my8100 / logparser

A tool for parsing Scrapy log files periodically and incrementally, extending the HTTP JSON API of Scrapyd.
GNU General Public License v3.0
89 stars 22 forks source link

v0.8.2: Support telneting with auth for Scrapy>=1.5.2 #13

Closed my8100 closed 5 years ago

pep8speaks commented 5 years ago

Hello @my8100! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 22:121: E501 line too long (158 > 120 characters)

Comment last updated at 2019-08-04 13:47:39 UTC
codecov[bot] commented 5 years ago

Codecov Report

Merging #13 into master will increase coverage by 0.27%. The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #13      +/-   ##
==========================================
+ Coverage   87.33%   87.61%   +0.27%     
==========================================
  Files           9        9              
  Lines         892      896       +4     
==========================================
+ Hits          779      785       +6     
+ Misses        113      111       -2
Impacted Files Coverage Δ
logparser/scrapylogparser.py 98.24% <100%> (+0.03%) :arrow_up:
logparser/__version__.py 100% <100%> (ø) :arrow_up:
logparser/settings.py 100% <100%> (ø) :arrow_up:
logparser/telnet.py 86.75% <75%> (+0.17%) :arrow_up:
logparser/utils.py 91.11% <0%> (+4.44%) :arrow_up: