search

mycontroller-org / mycontroller-v1-legacy

The Open Source Controller
http://www.MyController.org
Apache License 2.0
148 stars 90 forks source link

include webcomponents polyfill #483

Closed elgarfo closed 5 years ago

elgarfo commented 5 years ago

firefox does not include support for html imports (see: https://developer.mozilla.org/en-US/docs/Web/Web_Components/HTML_Imports) adding webcomponents 1.x polyfill fixes this issue, which in turn fixes https://github.com/mycontroller-org/mycontroller/issues/338

tested on:

jkandasa commented 5 years ago

@elgarfo Thank you for the PR! Your contribution to MyController is very valuable. MyController is designed to work without internet connectivity. You have given internet link. Could you please add this library under https://github.com/mycontroller-org/mycontroller/tree/development/dist/src/main/package/www/libs and provide the local reference?

Thank you!

elgarfo commented 5 years ago

@jkandasa the files are now local and i changed the reference in index.html. do you know what i need to do, to make the build successful? i can't seem to find the reason why the build is failing.

jkandasa commented 5 years ago

@elgarfo Thank you for the update. Looks like you have extra space on the following line(reported by travis CI), could you please remove it?

/home/travis/build/mycontroller-org/mycontroller/dist/src/main/package/www/index.html:74: Line has trailing spaces.
jkandasa commented 5 years ago

@elgarfo Thank you so much for your contribution!