search

myell0w / MTStatusBarOverlay

A custom iOS status bar overlay seen in Apps like Reeder, Evernote and Google Mobile App
MIT License
1.92k stars 325 forks source link

Added progress to UIStatusBarStyleTranslucent, User Interaction to History, and ability to remove from history #40

Closed rileytestut closed 12 years ago

rileytestut commented 12 years ago

You can now have MTStatusBarOverlay set to translucent and still have it display progress.

I've adjusted the size of the window when the history table view is displayed so you can interact with it (even in landscape mode ;) ). With this interaction, I've also added the ability to delete all messages from history, or deleting individual ones through code. To accomplish this, all messages posted now ask for a key so you can delete them individually.

Note: this was a modified version of MTStatusBarOverlay from some time ago. Although this is also ARC-enabled, I'm not sure what other changes you've made in the mean time.

myell0w commented 12 years ago

Hy!

Thank you very much for your pull request. Is it possible (or in other words: are you willing to) re-send this pull request starting from the current version? I changed quite a few things style-wise (e.g. removed all iVars etc.) and fixed a critical bug recently, and I would rather not re-introduce the risk of re-introducing bugs. I would love to see this merged but I currently can't promise to find the time anytime soon to go through your pull request and change everything to match the newest version, so I would be more than happy if you could re-send it starting from the current HEAD.

Please let me know if you are willing to do so,

cheers Matthias

rileytestut commented 12 years ago

Yes I'll be happy to do that :)

myell0w commented 12 years ago

any updates on this pull request? Would love to see this merged.

rileytestut commented 12 years ago

I still plan to finish it, but I've put it on hold to work on some of my projects. My implementation was not easy to port over, so I'd have to reimplement everything to make it fit the latest version.

But I'll get it done :)