Use IIFE & reflect NPM availibility

myforce / angularjs-dropdown-multiselect

AngularJS Dropdown Multiselect

http://myforce.github.io/angularjs-dropdown-multiselect/

MIT License

34 stars 28 forks source link

Use IIFE & reflect NPM availibility #40

Closed killzoner closed 7 years ago

killzoner commented 7 years ago

Hi,

This pull request suggests to use IIFE to avoid name collision between possible global function (ie find/findIndex/etc.) and actually relfect in the home page that the package is available on NPM.

I'm suggesting this pull request here and not in the main/original repo since I see no activity for a long time and i need NPM distro anyway.

pkempenaers commented 7 years ago

I've recently become the maintainer of the main repo so I'll merge it in there, I simply have a rather large backlog atm.

killzoner commented 7 years ago

Ok, good news then! Thanks for the work, tell me if i can help

pkempenaers commented 7 years ago

Could you create the same PR over there? (and rebase if needed) That'll make it simple for me to merge it in

killzoner commented 7 years ago

No problem i'll take care of it today

killzoner commented 7 years ago

Why do you mean by "over there"? The main repo?