search

myoung34 / docker-github-actions-runner

This will run the new self-hosted github actions runners with docker-in-docker
GNU General Public License v3.0
1.71k stars 399 forks source link

Isnt this Docker out of Docker? #381

Closed DavidJakszta closed 3 months ago

DavidJakszta commented 3 months ago

In the Per-Repo Runner exmaple on the wiki your bind mount -v /var/run/docker.sock:/var/run/docker.sock which means you dont use docker inside of docker but mount the outer docker daemon inside the container. Is this not mandatory or am i missing something? This seems like Docker out of Docker for me

myoung34 commented 3 months ago

That is how docker in docker works, but that isn't supported with actions upstream so you can skip that, it's not needed

DavidJakszta commented 3 months ago

What do you mean it's not supported by actions upstream? I just want to self-host a GHA with docker in docker (No socket mounting)

myoung34 commented 3 months ago

The readme links to the upstream issue. Docker is installed inside the image